-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure #380
Draft
theBGuy
wants to merge
475
commits into
mainline
Choose a base branch
from
restructure
base: mainline
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Restructure #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
theBGuy
commented
Jun 19, 2023
- Pretty much a complete re-write
This was
linked to
issues
Aug 18, 2023
- handle thrown errors, still unsure why sometimes the item reference is lost between when calling `castChargedSkill` but it's non-critical so don't end the script due to it
- add option to toggle flag that shows unit info. Command is `.info` in chat - fix typo in onChatInput
- check to see if it was us that picked the item, instead of relying on it simply no longer being of mode `onGroundOrDropping` when we go to log it
- occasionally these workers were running while wp screen was still loading causing game not ready warnings
- refactor pubjoin. Cleaned up location handling, moved config logic out of the entry with the exception of starter config settings. Unsure what to do with that for now
- remove debug print
- when building acceptfirst list, check that the partyflag is currently acceptable. Fixes bug that we were selecting a party member who we invited but wasn't accepting
- handle first login and checking/selecting realm from main menu - include handler on first join if clicking doesn't move us to the next location (seen this while using charon)
- handle item disappearing -> causing undefined gid
- convert to new format of using locations map and moving config logic out of the entry
- add `Array.at` definition - add `me.accessToAct` definition
- add min player count option - show charlvl in status bar
- convert lead entry to new format
- convert mulelog to new format
- Found out both bone armor and cyclone armor share a stat but for readability added it as `SkillCycloneArmor`
- found cyclonearmor max stat, update to use it - extend `PrecastSkill` class for the absorb armor skills - add `PrecastSkill.update` method
- add skillTab
- add getter for skillTab
- clean up `getBetterSlot` method
- rebuild channel joining, simplified being able to follow games by player name vs game names, with checks for private vs public games - easier format for setting up game/pass info - new format for entry
- add missing parameter
- Added option to create a character config if one wasn't found - Added utility method `log` - Added jsdoc - Fixed thrown errors from incorrect script names breaking the event handler and handle case sensitivity as it's annoyoing knowing we are trying to run `Baal` but typing `baal` and it failing
- Add optional third parameter on `isEqual` for toggling case sensitivity, it defaults to false meaning both strings with be downcased for comparison - Add `isType` method to replace repeat instances of `typeof val !== type` checks - Updated some missing type info
- The unique recipe constraint mostly affects soloplay, improves cubing resource allocation without having multiple identical recipes all trying to get ingredients - The lowgrand recipe is for rerolling grand charms for plain skillers
- The global decorators weren't exactly pollyfills, just things like sdk and global methods to make like easier so move them to their own file.
- Added lobby news and warning controls
- Minor cleanups, skip checking `playersIn` if they aren't in our party
- while loops with potential to go one forever are bad, replaced with polls for players changing act
- Allows running Duriel for extra chance at EoS
- Use chantlist to check for parent during autochant
- Always add the next game to the doneList when we get in game
…g.json` file - Update currAcc on successful log in
- Add stop command to halt wp giving
- Fixed ladderRws list
- Missed another typo
…impleParty - Changed + cleaned up the structure, removed usage of `this` instances - Added jsdoc comments - Added a broadcast event for updated default since it's paused during the duration of the hostileEvent - Added a check in findHostiles to remove players who were once hostile but no longer are but are still in game - Add a call into the town wait while loop to findHostiles in case the players aren't hostile anymore but are still in game so we don't wait around forever
…st since we are paused during that time
…s on the same thread - Keep a global set of the names in the shitList, this makes it simple for actions that share it like the `SimpleParty` thread and `ControlBot`
- Change `ngVote.watch` -> `ngVote.active` - Fix invalid `votesNeeded` count - Fix typo in `ngVote.checkCount`. `votesNeeded` is a method - Changed the help message back to in game chat vs whisper, noticed getting muted a lot when using whipser - Add handler so users don't cause the bot to spam the help message, if they've asked once this game then the help message exists in the logs they can check that
* add extra character to abbreviated name to prevent collision. small charm and small crescent now differ grand charm and grand crown now differ * there is no id building the itemquality>name map fix item * remove "debugging" code
Open
- Add check for non-ladder characters to see if there is an existing ladder file for the character and if so go ahead and remove it so we don't have duplicate data. Mostly affects droppers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.